Jeffrey Smith
619e6a040a
Some checks failed
CI/CD / detect-changes (pull_request) Successful in 5s
CI/CD / test-frontend (pull_request) Successful in 6s
CI/CD / test-go-pg (pull_request) Failing after 2m24s
CI/CD / test-sqlite (pull_request) Successful in 2m45s
CI/CD / build-and-deploy (pull_request) Has been skipped
Root causes:
- PG store CreateInstance/CreateAssignment set defaults in local vars
but didn't write them back to the struct, so callers saw empty
Status fields (violating CHECK constraints on subsequent updates)
- PG JSONB normalizes whitespace ({"key": "val"} vs {"key":"val"})
but tests compared exact strings
- ListSignoffs test used "nonexistent" as instance_id but PG
validates UUID format
Fixes:
- Write defaults directly to inst.Status / a.Status in PG store
(aligns with SQLite store which already did this)
- Add jsonEq() helper using json.Compact for whitespace-agnostic
JSON comparison across all stage_data/review_data assertions
- Use valid zero-UUID for non-existent instance in signoff test
All 35 tests pass on SQLite (28 store + 7 engine).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>