Jeffrey Smith
45448698d6
Three-tier settings resolution (global → team → user) with per-key user_overridable flag in package manifests. Admins can lock settings that team admins and users cannot override. - Add package_team_settings table (migration 010) - Add GetTeamSettings/SetTeamSettings/DeleteTeamSettings to PackageStore - Add ResolveSettings, ParseSettingsSchema, FilterOverridableKeys - Rewrite Starlark settings.get() to use cascade resolver - Add TeamID to RunContext for team-aware resolution - Enforce user_overridable on user settings save - Add team package settings API (GET/PUT/DELETE) - 12 unit tests for cascade resolution Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
91 lines
2.8 KiB
Go
91 lines
2.8 KiB
Go
package sandbox
|
|
|
|
// settings_module.go — v0.2.0
|
|
//
|
|
// The settings module lets extensions read their resolved settings via
|
|
// the three-tier cascade: global → team → user, respecting the
|
|
// user_overridable flag per setting key.
|
|
//
|
|
// Always injected (no permission required — a package reads its own settings).
|
|
//
|
|
// Starlark API:
|
|
// val = settings.get("key") # returns string, number, bool, or None
|
|
// val = settings.get("key", "default") # returns default if key not set
|
|
|
|
import (
|
|
"context"
|
|
|
|
"go.starlark.net/starlark"
|
|
"go.starlark.net/starlarkstruct"
|
|
|
|
"switchboard-core/store"
|
|
)
|
|
|
|
// BuildSettingsModule creates the "settings" Starlark module for a package.
|
|
// It resolves the three-tier cascade (global → team → user) respecting
|
|
// the user_overridable flag from the package manifest.
|
|
func BuildSettingsModule(ctx context.Context, stores store.Stores, packageID, userID, teamID string) *starlarkstruct.Module {
|
|
return MakeModule("settings", starlark.StringDict{
|
|
"get": starlark.NewBuiltin("settings.get", settingsGet(ctx, stores, packageID, userID, teamID)),
|
|
})
|
|
}
|
|
|
|
func settingsGet(ctx context.Context, stores store.Stores, packageID, userID, teamID string) func(*starlark.Thread, *starlark.Builtin, starlark.Tuple, []starlark.Tuple) (starlark.Value, error) {
|
|
return func(_ *starlark.Thread, _ *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
|
|
var key string
|
|
var defaultVal starlark.Value = starlark.None
|
|
if err := starlark.UnpackPositionalArgs("settings.get", args, kwargs, 1, &key, &defaultVal); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if stores.Packages == nil {
|
|
return defaultVal, nil
|
|
}
|
|
|
|
// Load global (admin) settings
|
|
globalSettings, err := stores.Packages.GetPackageSettings(ctx, packageID)
|
|
if err != nil {
|
|
globalSettings = nil
|
|
}
|
|
|
|
// Load team settings if team context is available
|
|
var teamSettings []byte
|
|
if teamID != "" {
|
|
ts, err := stores.Packages.GetTeamSettings(ctx, packageID, teamID)
|
|
if err == nil {
|
|
teamSettings = ts
|
|
}
|
|
}
|
|
|
|
// Load user settings if user context is available
|
|
var userSettings []byte
|
|
if userID != "" {
|
|
pus, err := stores.Packages.GetUserSettings(ctx, packageID, userID)
|
|
if err == nil && pus != nil {
|
|
userSettings = pus.Settings
|
|
}
|
|
}
|
|
|
|
// Parse schema from manifest for user_overridable flags
|
|
var schema []store.SettingSchema
|
|
pkg, err := stores.Packages.Get(ctx, packageID)
|
|
if err == nil && pkg != nil && pkg.Manifest != nil {
|
|
schema = store.ParseSettingsSchema(pkg.Manifest)
|
|
}
|
|
|
|
// Resolve cascade
|
|
merged := store.ResolveSettings(globalSettings, teamSettings, userSettings, schema)
|
|
|
|
val, ok := merged[key]
|
|
if !ok {
|
|
return defaultVal, nil
|
|
}
|
|
|
|
sv, err := goToStarlark(val)
|
|
if err != nil {
|
|
return defaultVal, nil
|
|
}
|
|
return sv, nil
|
|
}
|
|
}
|