switchboard/core
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Releases 9 Wiki Activity

Fix jsonEq to handle PG JSONB key reordering
All checks were successful
CI/CD / detect-changes (pull_request) Successful in 4s
Details
CI/CD / test-frontend (pull_request) Successful in 5s
Details
CI/CD / test-go-pg (pull_request) Successful in 2m29s
Details
CI/CD / test-sqlite (pull_request) Successful in 2m36s
Details
CI/CD / build-and-deploy (pull_request) Successful in 1m32s
Details

Browse Source 
PG JSONB normalizes key order (alphabetical), so json.Compact alone
wasn't sufficient — {"approved":true,"notes":"LGTM"} stored as
{"notes":"LGTM","approved":true}. Unmarshal+remarshal normalizes
both sides before comparison.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jeffrey Smith
2026-03-28 13:23:57 +00:00
parent 619e6a040a
commit fe176dbfdd
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
server/handlers/workflow_store_test.go
View File

@@ -14,17 +14,19 @@ import (
"switchboard-core/store/sqlite"
)
// jsonEq compares two JSON byte slices ignoring whitespace differences
// (PG JSONB normalizes spacing, SQLite preserves it verbatim).
// jsonEq compares two JSON byte slices ignoring whitespace and key order
// (PG JSONB normalizes spacing and may reorder keys).
func jsonEq(a, b json.RawMessage) bool {
var ca, cb bytes.Buffer
if err := json.Compact(&ca, a); err != nil {
var va, vb interface{}
if err := json.Unmarshal(a, &va); err != nil {
return false
}
if err := json.Compact(&cb, b); err != nil {
if err := json.Unmarshal(b, &vb); err != nil {
return false
}
return ca.String() == cb.String()
na, _ := json.Marshal(va)
nb, _ := json.Marshal(vb)
return bytes.Equal(na, nb)
}
// testStores returns an appropriate Stores for the current dialect.