switchboard/core
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Releases 9 Wiki Activity

Feat v0.9.2 Starlark converter consolidation + snapshot cleanup (#75)
All checks were successful
CI/CD / detect-changes (pull_request) Successful in 4s
Details
CI/CD / test-frontend (pull_request) Has been skipped
Details
CI/CD / test-runners (pull_request) Has been skipped
Details
CI/CD / e2e-smoke (pull_request) Has been skipped
Details
CI/CD / test-go-pg (pull_request) Successful in 2m43s
Details
CI/CD / test-sqlite (pull_request) Successful in 2m52s
Details
CI/CD / build-and-deploy (pull_request) Successful in 2m15s
Details

Browse Source 
Consolidate duplicate Go↔Starlark converters into sandbox/convert.go
and snapshot parsers into models/snapshot.go. Standardize snapshot
creation on wrapped format. Net -393 lines across 21 files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jeffrey Smith
2026-04-03 14:20:05 +00:00
parent d03dfe502f
commit b8a4c516ff
24 changed files with 362 additions and 479 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
server/workflow/engine.go
View File

@@ -18,25 +18,6 @@ import (
// MaxConsecutiveAutomated is the cycle guard limit for automated stages.
const MaxConsecutiveAutomated = 10
// parseSnapshotStages handles both snapshot formats:
// - Wrapped: {"stages": [...], "workflow": {...}} (from Publish handler)
// - Legacy: [...] (from early tests)
func parseSnapshotStages(raw json.RawMessage) ([]models.WorkflowStage, error) {
// Try wrapped format first
var wrapped struct {
Stages []models.WorkflowStage `json:"stages"`
}
if err := json.Unmarshal(raw, &wrapped); err == nil && len(wrapped.Stages) > 0 {
return wrapped.Stages, nil
}
// Fallback to flat array
var stages []models.WorkflowStage
if err := json.Unmarshal(raw, &stages); err != nil {
return nil, fmt.Errorf("corrupt version snapshot: %w", err)
}
return stages, nil
}
// Engine orchestrates workflow instance lifecycle.
type Engine struct {
stores store.Stores
@@ -64,7 +45,7 @@ func (e *Engine) Start(ctx context.Context, workflowID string, initialData json.
return nil, fmt.Errorf("no published version: %w", err)
}
stages, err := parseSnapshotStages(ver.Snapshot)
stages, err := models.ParseSnapshotStages(ver.Snapshot)
if err != nil {
return nil, err
}
@@ -142,7 +123,7 @@ func (e *Engine) advanceInternal(ctx context.Context, instanceID string, stageDa
return nil, fmt.Errorf("version not found: %w", err)
}
stages, err := parseSnapshotStages(ver.Snapshot)
stages, err := models.ParseSnapshotStages(ver.Snapshot)
if err != nil {
return nil, err
}
@@ -348,7 +329,7 @@ func (e *Engine) AdvancePublic(ctx context.Context, entryToken string, stageData
if err != nil {
return nil, fmt.Errorf("version not found: %w", err)
}
stages, err := parseSnapshotStages(ver.Snapshot)
stages, err := models.ParseSnapshotStages(ver.Snapshot)
if err != nil {
return nil, err
}
@@ -383,7 +364,7 @@ func (e *Engine) SubmitSignoff(ctx context.Context, instanceID, userID, decision
if err != nil {
return nil, fmt.Errorf("version not found: %w", err)
}
stages, err := parseSnapshotStages(ver.Snapshot)
stages, err := models.ParseSnapshotStages(ver.Snapshot)
if err != nil {
return nil, err
}
@@ -448,7 +429,7 @@ func CheckClaimRole(ctx context.Context, stores store.Stores, assignment *models
if err != nil {
return nil
}
stages, parseErr := parseSnapshotStages(ver.Snapshot)
stages, parseErr := models.ParseSnapshotStages(ver.Snapshot)
if parseErr != nil {
return nil
}