switchboard/core
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Releases 9 Wiki Activity

Feat v0.9.2 Starlark converter consolidation + snapshot cleanup (#75)
All checks were successful
CI/CD / detect-changes (pull_request) Successful in 4s
Details
CI/CD / test-frontend (pull_request) Has been skipped
Details
CI/CD / test-runners (pull_request) Has been skipped
Details
CI/CD / e2e-smoke (pull_request) Has been skipped
Details
CI/CD / test-go-pg (pull_request) Successful in 2m43s
Details
CI/CD / test-sqlite (pull_request) Successful in 2m52s
Details
CI/CD / build-and-deploy (pull_request) Successful in 2m15s
Details

Browse Source 
Consolidate duplicate Go↔Starlark converters into sandbox/convert.go
and snapshot parsers into models/snapshot.go. Standardize snapshot
creation on wrapped format. Net -393 lines across 21 files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jeffrey Smith
2026-04-03 14:20:05 +00:00
parent d03dfe502f
commit b8a4c516ff
24 changed files with 362 additions and 479 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
server/handlers/workflow_instance_handlers.go
View File

@@ -199,7 +199,7 @@ func (h *WorkflowInstanceHandler) enrichInstances(ctx context.Context, instances
// SLA check from version snapshot
ver, _ := h.stores.Workflows.GetVersion(ctx, inst.WorkflowID, inst.WorkflowVersion)
if ver != nil {
stages := parseSnapshotStagesForView(ver.Snapshot)
stages, _ := models.ParseSnapshotStages(ver.Snapshot)
for _, s := range stages {
if s.Name == inst.CurrentStage {
v.StageName = s.Name
@@ -217,18 +217,6 @@ func (h *WorkflowInstanceHandler) enrichInstances(ctx context.Context, instances
return views
}
func parseSnapshotStagesForView(snapshot json.RawMessage) []models.WorkflowStage {
var wrapped struct {
Stages []models.WorkflowStage `json:"stages"`
}
if err := json.Unmarshal(snapshot, &wrapped); err == nil && len(wrapped.Stages) > 0 {
return wrapped.Stages
}
var stages []models.WorkflowStage
json.Unmarshal(snapshot, &stages)
return stages
}
// CancelTeamInstance cancels an instance belonging to a team workflow.
// POST /api/v1/teams/:teamId/workflow-instances/:iid/cancel
func (h *WorkflowInstanceHandler) CancelTeamInstance(c *gin.Context) {