Changeset 0.22.8 (#150)

server/storage/pvc_test.go

@@ -24,7 +24,7 @@ func TestPVC_PutGetRoundTrip(t *testing.T) {
 	ctx := context.Background()
 
 	data := []byte("hello, storage world")
-	key := "attachments/channel-1/att-1_test.txt"
+	key := "files/channel-1/att-1_test.txt"
 
 	// Put
 	err := s.Put(ctx, key, bytes.NewReader(data), int64(len(data)), "text/plain")
@@ -56,7 +56,7 @@ func TestPVC_PutAtomicWrite(t *testing.T) {
 	s := tempStore(t)
 	ctx := context.Background()
 
-	key := "attachments/ch/file.bin"
+	key := "files/ch/file.bin"
 	data := []byte("atomic test data")
 
 	err := s.Put(ctx, key, bytes.NewReader(data), int64(len(data)), "application/octet-stream")
@@ -65,7 +65,7 @@ func TestPVC_PutAtomicWrite(t *testing.T) {
 	}
 
 	// File should exist at final path, no temp files left
-	absPath := filepath.Join(s.basePath, "attachments", "ch")
+	absPath := filepath.Join(s.basePath, "files", "ch")
 	entries, _ := os.ReadDir(absPath)
 	for _, e := range entries {
 		if e.Name() != "file.bin" {
@@ -79,7 +79,7 @@ func TestPVC_PutSizeMismatch(t *testing.T) {
 	ctx := context.Background()
 
 	data := []byte("short")
-	err := s.Put(ctx, "attachments/ch/f.txt", bytes.NewReader(data), 999, "text/plain")
+	err := s.Put(ctx, "files/ch/f.txt", bytes.NewReader(data), 999, "text/plain")
 	if err == nil {
 		t.Fatal("expected size mismatch error")
 	}
@@ -89,7 +89,7 @@ func TestPVC_GetNotFound(t *testing.T) {
 	s := tempStore(t)
 	ctx := context.Background()
 
-	_, _, _, err := s.Get(ctx, "attachments/nonexistent/file.txt")
+	_, _, _, err := s.Get(ctx, "files/nonexistent/file.txt")
 	if err != ErrNotFound {
 		t.Errorf("err = %v, want ErrNotFound", err)
 	}
@@ -99,7 +99,7 @@ func TestPVC_Delete(t *testing.T) {
 	s := tempStore(t)
 	ctx := context.Background()
 
-	key := "attachments/ch/delete-me.txt"
+	key := "files/ch/delete-me.txt"
 	_ = s.Put(ctx, key, bytes.NewReader([]byte("bye")), 3, "text/plain")
 
 	err := s.Delete(ctx, key)
@@ -118,7 +118,7 @@ func TestPVC_DeleteIdempotent(t *testing.T) {
 	ctx := context.Background()
 
 	// Delete a file that doesn't exist — should not error
-	err := s.Delete(ctx, "attachments/no-such/file.txt")
+	err := s.Delete(ctx, "files/no-such/file.txt")
 	if err != nil {
 		t.Errorf("Delete nonexistent: %v", err)
 	}
@@ -129,18 +129,18 @@ func TestPVC_DeletePrefix(t *testing.T) {
 	ctx := context.Background()
 
 	// Create several files under a channel prefix
-	prefix := "attachments/channel-abc/"
+	prefix := "files/channel-abc/"
 	for _, name := range []string{"a.txt", "b.png", "c.pdf"} {
 		key := prefix + name
 		_ = s.Put(ctx, key, bytes.NewReader([]byte("x")), 1, "text/plain")
 	}
 
 	// Also create a file in a different channel
-	other := "attachments/channel-other/keep.txt"
+	other := "files/channel-other/keep.txt"
 	_ = s.Put(ctx, other, bytes.NewReader([]byte("y")), 1, "text/plain")
 
 	// Delete the channel prefix
-	err := s.DeletePrefix(ctx, "attachments/channel-abc")
+	err := s.DeletePrefix(ctx, "files/channel-abc")
 	if err != nil {
 		t.Fatalf("DeletePrefix: %v", err)
 	}
@@ -165,7 +165,7 @@ func TestPVC_DeletePrefixNonexistent(t *testing.T) {
 	ctx := context.Background()
 
 	// Should not error
-	err := s.DeletePrefix(ctx, "attachments/does-not-exist/")
+	err := s.DeletePrefix(ctx, "files/does-not-exist/")
 	if err != nil {
 		t.Errorf("DeletePrefix nonexistent: %v", err)
 	}
@@ -175,7 +175,7 @@ func TestPVC_Exists(t *testing.T) {
 	s := tempStore(t)
 	ctx := context.Background()
 
-	key := "attachments/ch/exists.txt"
+	key := "files/ch/exists.txt"
 	_ = s.Put(ctx, key, bytes.NewReader([]byte("hi")), 2, "text/plain")
 
 	exists, err := s.Exists(ctx, key)
@@ -186,7 +186,7 @@ func TestPVC_Exists(t *testing.T) {
 		t.Error("Exists returned false for existing file")
 	}
 
-	exists, err = s.Exists(ctx, "attachments/ch/nope.txt")
+	exists, err = s.Exists(ctx, "files/ch/nope.txt")
 	if err != nil {
 		t.Fatalf("Exists (missing): %v", err)
 	}
@@ -220,7 +220,7 @@ func TestPVC_Stats(t *testing.T) {
 
 	// Add some files
 	for i := 0; i < 3; i++ {
-		key := filepath.Join("attachments", "ch", string(rune('a'+i))+".txt")
+		key := filepath.Join("files", "ch", string(rune('a'+i))+".txt")
 		data := bytes.Repeat([]byte("x"), 100*(i+1))
 		_ = s.Put(ctx, key, bytes.NewReader(data), int64(len(data)), "text/plain")
 	}
@@ -243,7 +243,7 @@ func TestPVC_PathTraversal(t *testing.T) {
 
 	bad := []string{
 		"../etc/passwd",
-		"attachments/../../etc/shadow",
+		"files/../../etc/shadow",
 		"/absolute/path",
 		"",
 	}
@@ -270,7 +270,7 @@ func TestPVC_SubdirCreation(t *testing.T) {
 	s := tempStore(t)
 
 	// Verify well-known subdirs were created
-	for _, sub := range []string{"attachments", "processing"} {
+	for _, sub := range []string{"files", "processing"} {
 		info, err := os.Stat(filepath.Join(s.basePath, sub))
 		if err != nil {
 			t.Errorf("subdir %q not created: %v", sub, err)