switchboard/core
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Releases 9 Wiki Activity

Fix auth cookie name (arm_token) + separate Run All from suite count
Some checks failed
CI/CD / detect-changes (pull_request) Successful in 4s
Details
CI/CD / test-frontend (pull_request) Successful in 5s
Details
CI/CD / test-runners (pull_request) Failing after 2m34s
Details
CI/CD / test-sqlite (pull_request) Successful in 3m8s
Details
CI/CD / test-go-pg (pull_request) Successful in 3m16s
Details
CI/CD / build-and-deploy (pull_request) Has been skipped
Details

Browse Source 
1. The driver set cookie name 'token' but the server uses 'arm_token',
   so Playwright always saw the login page instead of the surface.

2. Split "Run All (N suites)" into a "Run All" button + separate
   suite count label — count changes over time and shouldn't be
   part of the button text.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jeffrey Smith
2026-04-02 11:26:59 +00:00
parent f5f9526f8a
commit 4a3be4913f
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ci/surface-test-driver.js
View File

@@ -33,9 +33,9 @@ if (!TOKEN) {
const browser = await chromium.launch({ headless: true }); const browser = await chromium.launch({ headless: true });
const context = await browser.newContext(); const context = await browser.newContext();
// Set auth cookie/token // Set auth cookie — name must match server's SetCookie ("arm_token")
await context.addCookies([{ await context.addCookies([{
name: 'token', name: 'arm_token',
value: TOKEN, value: TOKEN,
domain: new URL(SERVER).hostname, domain: new URL(SERVER).hostname,
path: '/', path: '/',

2
packages/test-runners/js/main.js
View File

@@ -326,7 +326,7 @@
<h2>Test Runners</h2> <h2>Test Runners</h2>
${props.running ${props.running
? html`<span class="ext-test-runners-running"><span class="ext-test-runners-spinner"></span> Running${props.runningSuite === 'all' ? ' all' : ''}...</span>` ? html`<span class="ext-test-runners-running"><span class="ext-test-runners-spinner"></span> Running${props.runningSuite === 'all' ? ' all' : ''}...</span>`
: html`<button class="sw-btn sw-btn--primary" onClick=${props.onRunAll}>Run All (${props.suiteCount} suites)</button>` : html`<button class="sw-btn sw-btn--primary" onClick=${props.onRunAll}>Run All</button> <span class="ext-test-runners-suite-count">${props.suiteCount} suites</span>`
} }
${s ? html` ${s ? html`
<div class="ext-test-runners-summary"> <div class="ext-test-runners-summary">